Skip to content

Fix string equality warnings in SplineFit class #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix string equality warnings in SplineFit class #147

merged 1 commit into from
Dec 30, 2024

Conversation

@scastro-bdai
Copy link
Contributor

@scastro-bdai scastro-bdai commented Dec 19, 2024 •
edited
Loading

We've started getting some loud warnings about using is instead of == when checking string values.

/usr/local/lib/python3.10/dist-packages/spatialmath/spline.py:195: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if check_type is "local":
/usr/local/lib/python3.10/dist-packages/spatialmath/spline.py:202: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif check_type is "global":

This small PR should resolve that.

Closes #146

@scastro-bdai
Fix string equality warnings in SplineFit class
0808fbf 
We've started getting some loud warnings about using `is` instead of `==` when checking string values.

This small PR should resolve that.
glvov-bdai
glvov-bdai approved these changes Dec 19, 2024
View reviewed changes
Copy link

@glvov-bdai glvov-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for putting that in excited to silence the unneeded output

@jcao-bdai jcao-bdai merged commit 3d21b06 into master Dec 30, 2024
15 checks passed
@jcao-bdai jcao-bdai deleted the fix-spline-string-equality-warnings branch December 30, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsurovik-bdai dsurovik-bdai dsurovik-bdai approved these changes

@jbarnett-bdai jbarnett-bdai jbarnett-bdai approved these changes

@petercorke petercorke Awaiting requested review from petercorke petercorke is a code owner

@jhavl jhavl Awaiting requested review from jhavl jhavl is a code owner

@myeatman-bdai myeatman-bdai Awaiting requested review from myeatman-bdai myeatman-bdai is a code owner

+1 more reviewer

@glvov-bdai glvov-bdai glvov-bdai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Ruff warnings

5 participants

@scastro-bdai @dsurovik-bdai @glvov-bdai @jbarnett-bdai @jcao-bdai